Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get going with new S3 backend #2

Merged
merged 13 commits into from
Feb 22, 2024
Merged

Get going with new S3 backend #2

merged 13 commits into from
Feb 22, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Feb 21, 2024

No description provided.

@FynnBe FynnBe requested a review from jmetz February 21, 2024 14:16
@FynnBe FynnBe marked this pull request as ready for review February 21, 2024 14:16
Copy link
Contributor

@jmetz jmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, though haven't explicitly tested (as I don't have local testing setup for full CI workflow)

.github/workflows/stage_call.yaml Show resolved Hide resolved
scripts/upload_model_to_zenodo.py Show resolved Hide resolved
@FynnBe FynnBe merged commit acdc0c8 into main Feb 22, 2024
3 of 4 checks passed
@FynnBe FynnBe deleted the get_going branch February 22, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants