Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish workflow #3

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Add publish workflow #3

merged 7 commits into from
Feb 22, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Feb 22, 2024

No description provided.

@FynnBe FynnBe requested a review from jmetz February 22, 2024 08:53
@jmetz
Copy link
Contributor

jmetz commented Feb 22, 2024

@FynnBe - could you share / let me know what local testing you're using for workflows? Are you using the local actions runner that we discussed a short while ago still or more just doing local testing of the python scripts called by the workflows?

@oeway
Copy link
Contributor

oeway commented Feb 22, 2024

Great to see the work here! Thank you both!

@FynnBe
Copy link
Member Author

FynnBe commented Feb 22, 2024

@FynnBe - could you share / let me know what local testing you're using for workflows? Are you using the local actions runner that we discussed a short while ago still or more just doing local testing of the python scripts called by the workflows?

I now only test with pytest locally and try to have the pytests map all processes.
Also I try to keep the workflows very light, e.g. call only one script.
And then testing online (test.yaml) workflow isn't so painful when pytests pass locally

@FynnBe FynnBe marked this pull request as ready for review February 22, 2024 10:31
@FynnBe FynnBe merged commit 86d5752 into main Feb 22, 2024
3 of 4 checks passed
@FynnBe FynnBe deleted the add_publish branch February 22, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants