Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Use ISO language setting in widgets #1034

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Jan 26, 2024

Issue

In the beginning, I was keeping language names in widget settings. It turned out it is better to keep languages as ISO codes since language names can change in the future (like we did with Ancient Greek), but ISO codes will probably not.

This

Description of changes
  • It should fix the issue reported in [ENH] UDPIPE - Use ISO language codes  #1030
  • Change the Ancient greek language to Ancient Greek to be compatible with other languages (and compatible with ISO standards).
  • Keep languages as ISO codes in settings to bypass problems with language name changes and easier management.
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the iso-lang-settings branch 3 times, most recently from b3da9ff to c22beed Compare January 26, 2024 13:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Merging #1034 (c6a7082) into master (e7c360d) will increase coverage by 0.23%.
The diff coverage is 92.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   82.18%   82.42%   +0.23%     
==========================================
  Files          92       92              
  Lines       12283    12322      +39     
  Branches     1670     1678       +8     
==========================================
+ Hits        10095    10156      +61     
+ Misses       1880     1855      -25     
- Partials      308      311       +3     

@PrimozGodec PrimozGodec marked this pull request as ready for review January 26, 2024 13:58
@PrimozGodec PrimozGodec assigned PrimozGodec and VesnaT and unassigned PrimozGodec Jan 26, 2024
@VesnaT VesnaT merged commit 2ca7d7c into biolab:master Feb 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants