Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Corpus - extend attributes: Fix error with renamed text feature #574

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

PrimozGodec
Copy link
Collaborator

Issue

When in extednd_attributes function one of the text features is renamed extending fails with ValueError.

Description of changes

Changed set_text_features function to handle cases with renamed features (when the feature has Identity in compute_values).

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #574 into master will increase coverage by 3.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   70.86%   73.90%   +3.03%     
==========================================
  Files          66       66              
  Lines        7565     7575      +10     
  Branches      999     1002       +3     
==========================================
+ Hits         5361     5598     +237     
+ Misses       2011     1767     -244     
- Partials      193      210      +17     

@ajdapretnar ajdapretnar merged commit 58ab7b9 into biolab:master Oct 2, 2020
@PrimozGodec PrimozGodec deleted the fix-feature-not-found branch March 29, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants