[FIX] Keywords - Handle connection error #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
==========================================
+ Coverage 79.66% 79.72% +0.06%
==========================================
Files 87 87
Lines 12319 12332 +13
Branches 1617 1620 +3
==========================================
+ Hits 9814 9832 +18
+ Misses 2211 2209 -2
+ Partials 294 291 -3 |
janezd
reviewed
Aug 20, 2023
| kws = func(corpus if needs_tokens else documents, **kw) | ||
| # None means that embedding completely failed on document | ||
| # currently it only happens with mbert when connection fails | ||
| keywords = [kws for kws in kws if kws is not None] |
There was a problem hiding this comment.
Minor comment: I'd have for kw in kws; because it's singular and also because somebody (who doesn't know that this was fixed in Python 3) would fear that kws would be leaked out of list comprehension.
I'm merging as it is; if you want, just push a commit with this change into master. :)
There was a problem hiding this comment.
It was actually my mistake (probably while making some changes). Agree to the use of the singular. I will fix it on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #890
Description of changes
Handle connection errors and warn users about them.
Includes