Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dask: PCA #6445

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Dask: PCA #6445

merged 3 commits into from
Jun 23, 2023

Conversation

noahnovsak
Copy link
Contributor

@noahnovsak noahnovsak commented May 12, 2023

extend PCA to use dask_ml when necessary.

  • still waiting for preprocessors
  • __call__ method reimplemented to avoid using self.domain
  • fit method no longer returns PCAModel

@markotoplak
Copy link
Member

@noahnovsak, could you please rebase this to the now-rebased dask branch? The easiest way is to start with dask branch and just move the new commits there.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #6445 (b176d28) into dask (2f0bec2) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             dask    #6445   +/-   ##
=======================================
  Coverage   87.64%   87.65%           
=======================================
  Files         322      322           
  Lines       69601    69622   +21     
=======================================
+ Hits        61002    61025   +23     
+ Misses       8599     8597    -2     

@noahnovsak noahnovsak changed the title dask compatible pca Dask: PCA Jun 9, 2023
@markotoplak
Copy link
Member

Looks good. Could you add some tests so that we'll know when if we break ti?

@noahnovsak noahnovsak force-pushed the dask-pca branch 2 times, most recently from 2aa8dbb to 44226a8 Compare June 22, 2023 12:28
@markotoplak markotoplak merged commit 97751d4 into biolab:dask Jun 23, 2023
14 of 22 checks passed
@noahnovsak noahnovsak deleted the dask-pca branch June 23, 2023 08:47
markotoplak added a commit that referenced this pull request Jun 28, 2023
markotoplak added a commit that referenced this pull request Jul 12, 2023
markotoplak added a commit that referenced this pull request Jul 14, 2023
markotoplak added a commit that referenced this pull request Jul 20, 2023
markotoplak added a commit to markotoplak/orange3 that referenced this pull request Jul 26, 2023
markotoplak added a commit that referenced this pull request Aug 15, 2023
markotoplak added a commit that referenced this pull request Aug 17, 2023
markotoplak added a commit that referenced this pull request Aug 21, 2023
markotoplak added a commit that referenced this pull request Sep 4, 2023
markotoplak added a commit that referenced this pull request Sep 14, 2023
markotoplak added a commit to markotoplak/orange3 that referenced this pull request Sep 14, 2023
markotoplak added a commit that referenced this pull request Sep 18, 2023
markotoplak added a commit that referenced this pull request Sep 26, 2023
markotoplak added a commit that referenced this pull request Oct 10, 2023
markotoplak added a commit that referenced this pull request Oct 13, 2023
markotoplak added a commit that referenced this pull request Oct 21, 2023
markotoplak added a commit that referenced this pull request Oct 29, 2023
markotoplak added a commit that referenced this pull request Nov 6, 2023
markotoplak added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants