-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask: Linear Regression #6513
Dask: Linear Regression #6513
Conversation
c49532f
to
7f067a2
Compare
Orange/statistics/util.py
Outdated
@@ -562,7 +562,7 @@ def nanmode(x, axis=0): | |||
def unique(x, return_counts=False): | |||
""" Equivalent of np.unique that supports sparse or dense matrices. """ | |||
if not sp.issparse(x): | |||
return np.unique(x, return_counts=return_counts) | |||
return np.unique(np.asarray(x), return_counts=return_counts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember who called unique?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in owlearnerwidget there's a check_data
method, that makes sure that (among other things) Y isn't constant. I can move the computation up there instead if that makes more sense.
7f067a2
to
c725172
Compare
7b036ca
to
f9547a3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dask #6513 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 322 322
Lines 69937 69981 +44
=======================================
+ Hits 61340 61379 +39
- Misses 8597 8602 +5 |
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
[ENH] Dask: Linear Regression
LinearRegressionLearner and the corresponding widget now support DaskTables.