Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup.py to work with Cython 3.0 #6521

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jul 20, 2023

Issue

Fixes #6519.

Cython 3.0 with current setup.py cythonizes pyx -> c, but doesn't call compiler.

Description of changes

Call cythonize. Whyever.

I checked that there should be no problems with new default behaviour of / ("true division", producing floats). In most pyx files we specifiy cdivision=True anyway, so the behaviour of Cython remained the same).

If this is OK, we need to

Interestingly, with addon Associate we distribute .cpp. When was the last time anybody touched that add-on?

@janezd janezd changed the title Change setup.py for Cython 3.0 [WIP] Change setup.py for Cython 3.0 Jul 20, 2023
@janezd janezd changed the title [WIP] Change setup.py for Cython 3.0 Change setup.py for Cython 3.0 Jul 20, 2023
@janezd janezd changed the title Change setup.py for Cython 3.0 Change setup.py to work with Cython 3.0 Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #6521 (c6b6d4e) into master (601b7dc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6521   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         321      321           
  Lines       69371    69371           
=======================================
  Hits        60830    60830           
  Misses       8541     8541           

@markotoplak
Copy link
Member

If we call cythonize manually I see no reason to use cython's build_ext.

I have no idea why this PR changes anything. @ales-erjavec, could you comment on this PR?

@markotoplak markotoplak merged commit 50df82a into biolab:master Jul 24, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of cython was released, installation does not work with it
3 participants