Edit Domain: allow the (existing) checkbox to also control removal of newly created compute value #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
edit-domain-unlink-forward
branch
from
960f78b
to
d36df7f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6604 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 321 321
Lines 69876 69875 -1
=======================================
+ Hits 61563 61566 +3
+ Misses 8313 8309 -4 |
|
LGTM, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6566. See in particular #6566 (comment).
Description of changes
The first commit does the job and is trivial: checkbox is no longer disabled, and having
compute_valueis no longer required for unlinking.The second commit is not needed for fixing #6566. However, now that
compute_valueis no longer required for unlinking, we do not need to check it in hint matching. I thus removed it from the key in hint dictionary and consequently from settings. This required a zillion small changes in tests (removals of the additional argument), settings migration and tests for settings migration.Includes