adaboost: adapt to scikit-learn's 1.4 deprecation of base_estimator #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
adaboost-base-estimator
branch
from
1231f47
to
fc3d06d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6637 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 321 321
Lines 69930 69942 +12
=======================================
+ Hits 61616 61628 +12
Misses 8314 8314 |
markotoplak
force-pushed
the
adaboost-base-estimator
branch
from
70a5501
to
6a3046b
Compare
markotoplak
force-pushed
the
adaboost-base-estimator
branch
2 times, most recently
from
cde44e2
to
ad23f30
Compare
lanzagar
reviewed
Nov 24, 2023
| @@ -2010,14 +2010,18 @@ distance/distance.py: | |||
| def `compute_distances`: | |||
| hamming: false | |||
| ensembles/ada_boost.py: | |||
| def `base_estimator_deprecation`: | |||
| '`base_estimator` is deprecated (to be removed in 3.39): use `estimator` instead.': false | |||
There was a problem hiding this comment.
This should not be false. I think you either provide a translation or leave it null for someone else to translate it later.
There was a problem hiding this comment.
It's OK, this message is not intended to be seen by the user. It should be in English.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
/home/runner/work/orange3/orange3/.tox/orange-latest/lib/python3.11/site-packages/sklearn/ensemble/_base.py:156: FutureWarning:
base_estimatorwas renamed toestimatorin version 1.2 and will be removed in 1.4.Description of changes
Includes