Minor fixes in Mosaic and Sieve vizrank #6677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
vizrank-disable-when-no-data
branch
from
8d5304e
to
44b3cb9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6677 +/- ##
==========================================
- Coverage 88.09% 88.08% -0.01%
==========================================
Files 322 322
Lines 70102 70106 +4
==========================================
Hits 61755 61755
- Misses 8347 8351 +4 |
janezd
force-pushed
the
vizrank-disable-when-no-data
branch
from
44b3cb9
to
8a63502
Compare
VesnaT
reviewed
Dec 15, 2023
Orange/widgets/visualize/owmosaic.py
Outdated
| @@ -395,7 +404,7 @@ def set_data(self, data): | |||
|
|
|||
| def init_vizrank(self): | |||
| if self.data is not None and len(self.data) > 1 \ | |||
| and len(self.data.domain.attributes) >= 1: | |||
| and len(self.data.domain.attributes) >= 2: | |||
There was a problem hiding this comment.
The condition should be applied to len(self.data.domain.variables + self.data.domain.metas). (The mosaic is build upon all variables in the domain).
janezd
force-pushed
the
vizrank-disable-when-no-data
branch
from
8a63502
to
a66c3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Minor improvements over #6661.
Description of changes
Mosaic:
Sieve:
caption_title.Includes