Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] ScoringSheet and ScoringSheetViewer widgets added #6817

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZanMervic
Copy link
Contributor

Issue

Added Scoring Sheet and Scoring Sheet Viewer widgets (transferred from the prototypes addon).

Description of changes
  • Transferred two new widgets from the prototypes addon: the Scoring Sheet and Scoring Sheet Viewer.
  • Included documentation and tests for both widgets.
Notice

One of the additions is the FasterRisk source code, copied from the following repository: https://github.com/jiachangliu/FasterRisk.

This inclusion serves as a temporary solution to address compatibility and functionality issues arising from the strict requirements of the original package. It will remain in place until the original maintainer updates the package to resolve these issues.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member

@ZanMervic, could you check and fix the test errors? For starters, this learner needs to be usable without parameters (just make up some defaults) and needs to be imported in the correct module:

https://github.com/biolab/orange3/actions/runs/9328865142/job/25680578428?pr=6817

It should also be somehow obvious that fasterrisk is not another module with Orange learners. I would suggest making a classification.utils and put fasterrisk there.

@ZanMervic ZanMervic changed the title ScoringSheet and ScoringSheetViewer widgets added [ENH] ScoringSheet and ScoringSheetViewer widgets added Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants