[FIX] ListView: Fix selection #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
added
the
waiting for new dependency version
markotoplak
force-pushed
the
list_view
branch
from
4a55ed4
to
bfe44fc
Compare
markotoplak
removed
the
waiting for new dependency version
|
orange-widget-base 4.25.0 with the needed change was released. I thus rebased this PR to master. Is there anything else needed before merging it? Was it already reviewed with the accompanying request? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6823 +/- ##
=========================================
Coverage ? 88.41%
=========================================
Files ? 326
Lines ? 71946
Branches ? 0
=========================================
Hits ? 63610
Misses ? 8336
Partials ? 0 |
Yes, we were just waiting for a new release of orange-widget-base. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Needs biolab/orange-widget-base#274
Description of changes
Includes