[FIX] oweditdomain: Hide "categories mapping" warning on change

[ales-erjavec]

Issue

Fixes: #6861

Description of changes

• Hide/show warning on change
• Indicate items with a warning with a yellow color

Includes

• Code changes
• Tests
• Documentation

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (09df730) to head (27280fd).
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6865      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.01%     
==========================================
  Files         326      326              
  Lines       71142    71166      +24     
==========================================
+ Hits        62797    62828      +31     
+ Misses       8345     8338       -7     

[ajdapretnar]

I apologise but I don't properly see the difference after the fix. I do like the highlight of the changed variable, although it would be better probably to use yellow as a background highlight (yellow letters are difficult to see on white). But the warning behaviour is still identical for me (or am I missing something)?

The user says <"A" if 0 else "B">. Then she changes this to <"C" if 0 else "B">. The warning says the mapping doesn't apply to the current input. But it does (i.e. should be updated in the background). The only thing that has changed was how I want to name my value ("C" instead of "A")? So in my opinion, there should be no warning. Even the widget Edit Domain shows the mapping worked (it changes "A" to "C").

It is entirely possible I don't understand the issue here.

[janezd]

Just a minor comment: yellow looks nice in dark mode, but is difficult to see on white background. Could you change it to a color that is visible in both modes, or choose different colors for different modes?

[wvdvegte]

I agree with @ajdapretnar (if I understand her correctly): it should be possible to change the name of a category on the input of Edit Domain, or even add new categories, and this should be updated in the background. Actually, in current Orange 3.37.0 it is updated in the background - and everything works fine, even if new categories are added: the changes appear in the output of Edit Domain, as intended (I just checked). There just shouldn't be a warning!