[FIX] SVM: degree has to be an integer #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
fix-svm-degree
branch
from
ec73c5e
to
9cc421b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6866 +/- ##
==========================================
- Coverage 88.26% 88.26% -0.01%
==========================================
Files 326 326
Lines 71142 71148 +6
==========================================
+ Hits 62797 62800 +3
- Misses 8345 8348 +3 |
|
So is this issue resolved now? |
|
The SVMs will work in the next released version (or if you install the dev version). |
This is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixed #6853
Description of changes
A spin for doubles was used for degrees - now it is not anymore. I also took care of transitioning saved settings.
Includes