Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical clustering: Allow more than 20 clusters in Top n spin #6887

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Sep 6, 2024

Issue

Fixes #6883.

Description of changes

The spin box expects some maximum value; Qt's default is 99. I set it to 1000, but the widget will show a warning if the value is above 20.

The warning checks the final number of clusters. It won't be shown if Top N setting is too high, but there are not enough data instances for so many clusters. And the warning is also shown when >20 clusters are obtained in some other way, either manually or via treshold.

Includes
  • Code changes
  • Tests

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (6c742f7) to head (2a6f878).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6887      +/-   ##
==========================================
- Coverage   88.26%   88.26%   -0.01%     
==========================================
  Files         326      326              
  Lines       71184    71188       +4     
==========================================
  Hits        62834    62834              
- Misses       8350     8354       +4     

@lanzagar lanzagar merged commit 2c966b7 into biolab:master Sep 20, 2024
21 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierechical clustering: allow Top N > 20
2 participants