fix(grit): broaden GritQL parser support #4978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
CodSpeed Performance ReportMerging #4978 will not alter performanceComparing Summary
|
ematipico
requested changes
Jan 27, 2025
Comment on lines
+93
to
+94
| // Comments inside the JS are not allowed | ||
| let mut brace_count = 0; |
There was a problem hiding this comment.
If comments aren't allowed inside JS functions, maybe we should create a new lexer context, where we raise a parsing diagnostic every time we encounter a comment. At the moment it doesn't seem we do
| p.expect(T!['}']); | ||
| } else { | ||
| parse_curly_predicate_list(p).ok(); | ||
| } | ||
|
|
||
| Present(m.complete(p, GRIT_FUNCTION_DEFINITION)) |
There was a problem hiding this comment.
Shouldn't we use the new JavaScript function node here?
| node: &GritJavascriptFunctionDefinition, | ||
| f: &mut GritFormatter, | ||
| ) -> FormatResult<()> { | ||
| format_verbatim_node(node.syntax()).fmt(f) |
There was a problem hiding this comment.
We should implement the formatting while we're at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a few more issues with the GritQL parser/formatter that failed on complex patterns from https://github.com/getgrit/stdlib
Test Plan
Spec tests are included