-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update lefthook example #662
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@nhedger is the change make sense to you? You used lefthook before |
I've never used Would you be willing to provide a reproduction @AkaraChen ? |
Here's the step by step guide to reproduce: |
Thanks for the detailed reproduction; this helped a lot! I can reproduce the issue by following your instructions, but I suspect that the pattern specified in Using the following value as What I can't yet explain, though, is why setting the @ematipico do we allow specifying folders as-is in the includes, or is it mandatory to specify a glob that matches files. |
Here're some relative discussions on this glob match behavior: biomejs/biome#2131 (comment) |
It's possible that with this setting, lefthook computes the paths differently, which results in matching the glob specified. However, if there's an issue, it's definitely around globs and not how lefthook should be set up. |
Summary
If the
root
of the lefthook command is not specified,biome check
will not followbiome.json[overrides]