Enhance I/O feedback on GUI #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrascomj
force-pushed
the
enhance-info-gui
branch
4 times, most recently
from
e1ba6c7
to
be3d721
Compare
carrascomj
force-pushed
the
enhance-info-gui
branch
from
be3d721
to
dac3ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reviewers pointed out that there was not enough feedback about I/O in the GUI, especially when there are errors in reading files.
Implementation
A popup is used to communicate in the UI the logged information about I/O. This includes errors but also "Loading" messages for when maps or data take some time to load (should not happen on a normal computer but maybe on WASM on a smartphone).
The popup fades out after 3 seconds if not hovered.