Improve template logging #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsu
approved these changes
Aug 19, 2024
colleenXu
approved these changes
Aug 20, 2024
|
When I run the issue's queries, here's the logs I now see. I agree that this looks good: 1st template (no merging sentence!): 2nd template (no results): 3rd template (no results): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses biothings/biothings_explorer#848
After templates, the summary log will now read like so:
Template Summary: Template-2 returned 45 results. (3) of these were merged with results from previous templates. Total result count is 67 (increased by 42)In addition, the first template will not log the count of results merged with previous templates, as there are none.