fix: Don't request clipboardWrite permission for Chromium browsers

birchill · Jun 17, 2021 · 787da9c · 787da9c
1 parent 1d34cd4
commit 787da9c
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.5.13 (2021-06-17)
+
+- Drop `clipboardWrite` property from Chromium manifest since it's not needed
+  there.
+
 ## 0.5.12 (2021-06-17)
 
 - Fix some bugs in the lookup cache

diff --git a/manifest.json.src b/manifest.json.src
@@ -32,7 +32,9 @@
   },
   /*#endif*/
   "permissions": [
+    /*#if needs_clipboard_write*/
     "clipboardWrite",
+    /*#endif*/
     "contextMenus",
     "storage",
     "tabs",

diff --git a/webpack.config.js b/webpack.config.js
@@ -136,6 +136,7 @@ if (process.env.RELEASE_BUILD && process.env.BUGSNAG_API_KEY) {
 const chromeConfig = buildExtConfig({
   distFolder: 'dist-chrome',
   includeChromeWebStoreIcons: true,
+  needsClipboardWrite: false,
   supportsChromeStyle: true,
   supportsMatchAboutBlank: true,
   target: 'chromium',
@@ -144,6 +145,7 @@ const chromeConfig = buildExtConfig({
 const edgeConfig = buildExtConfig({
   distFolder: 'dist-edge',
   includeChromeWebStoreIcons: true,
+  needsClipboardWrite: false,
   supportsMatchAboutBlank: true,
   target: 'chromium',
   usesEdgeStore: true,
@@ -165,6 +167,7 @@ module.exports = (env) => {
 function buildExtConfig({
   distFolder,
   includeChromeWebStoreIcons = false,
+  needsClipboardWrite = true,
   supportsAlphaVersion = false,
   supportsApplicationsField = false,
   supportsBrowserStyle = false,
@@ -175,6 +178,10 @@ function buildExtConfig({
   usesEdgeStore = false,
 }) {
   const preprocessorFeatures = [];
+  if (needsClipboardWrite) {
+    preprocessorFeatures.push('needs_clipboard_write');
+  }
+
   if (supportsAlphaVersion) {
     preprocessorFeatures.push('supports_alpha_version');
   }