This repository has been archived by the owner on May 28, 2024. It is now read-only.
Move necessary front-end deps to prod #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the following dependencies from dev to prod as they are needed to build/run the front-end service.
@types/jest**@types/react@types/react-dom@types/react-reduxtypescriptAdds a dependency of
styled-componentsand corresponding@types/styled-componentsdevDependency as this is also needed.Test with the following from the
front-endfolder:** It seems weird that
@types/jestshould be a prod dependency, but it doesn't compile otherwise asApp.test.txlives insidesrc/componentsThis PR also updates the
package-lockto correspond with these changes but this file should maybe be removed from git as per the main .gitignore file (and there isn't one in thebackendfolder).