Version 0.17.1 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use grace for signal handling and fork/spawn. - Add shutdown hooks for per app handling. - Wait group for server handler to ensure all requests are completed. - Only use for the server, not the harness. * Required output for harness to work.
birkirb
commented
Feb 26, 2018
params.go
Outdated
| Files map[string][]*multipart.FileHeader // Files uploaded in a multipart form | ||
| tmpFiles []*os.File // Temp files used during the request. | ||
| JSON []byte // JSON data from request body | ||
| JSON []byte |
server.go
Outdated
| @@ -127,15 +131,15 @@ func Run(port int) { | |||
| port = HTTPPort | |||
| } | |||
|
|
|||
| var network = "tcp" | |||
| // var network = "tcp" | |||
birkirb
commented
Feb 27, 2018
| var localAddress string | ||
|
|
||
| // If the port is zero, treat the address as a fully qualified local address. | ||
| // This address must be prefixed with the network type followed by a colon, | ||
| // e.g. unix:/tmp/app.socket or tcp6:::1 (equivalent to tcp6:0:0:0:0:0:0:0:1) | ||
| if port == 0 { | ||
| parts := strings.SplitN(address, ":", 2) | ||
| network = parts[0] | ||
| // network = parts[0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.