Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MinimalKnob.svelte #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zkramer22
Copy link

@zkramer22 zkramer22 commented Sep 18, 2024

added new textColor prop to MinimalKnob, and passed it to MinimalKnob's Input component via color prop. This allows for the number value, the background svg, and the fill color svgs to all be different colors if desired.
Screenshot 2024-09-18 at 12 12 39 PM

added separate textColor prop within MinimalKnob
@zkramer22
Copy link
Author

I was having trouble following your instructions in the README for editing a file.

installed via "npm install @bismuthsoft/svelte-dj-knob"
copied MinimalKnob.svelte into my project's /src/lib/
updated MinimalKnob.svelte to allow separation of textColor and bgColor (i wanted dark gray background, white text, and a variable colored fill).
changed "$lib" to "@bismuthsoft/svelte-dj-knob" in my project's new file MinimalKnob.svelte

doing this was not working. I tried forking the repo, but that didn't work either. Something wrong with the way my project was importing and exporting files.

I ended up just modifying these 2 lines of code directly in node_modules with your original package installed.

Let me know if you want some more detailed error screenshots I can provide them!

And thanks for this repository it is exactly what i was looking for, all the other HTML knob elements are too realistic. No one actually wants to use a mouse pointer in a circular motion around a knob. Haha. Cheers m8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant