Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if Include folders/files do exists (in case they are removed) #1718
base: dev
Are you sure you want to change the base?
Check if Include folders/files do exists (in case they are removed) #1718
Changes from 1 commit
f6bf5bc
d4556ca
5f3a8c7
e07d5a1
ce4d761
27fe2da
27ac817
4f36503
9cb8348
7472f54
287d129
5161ccd
45aa011
c2941ba
6668487
205ee49
03c1050
bb5969c
5416356
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if
os.path.exists()
does also work for files (though folders are files), could you please (manually) check this with a configuration that contains a "missing" and an "existing" file (positive and negative test)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I just did it and it worked fine :)
I tested via CLI:
I tested w/ CLI, and got correct results w/ this warning:
And also via GUI with real snapshots (w/ existent folder, removed folder, existent file and removed file).