fix: Reset cached SSH password when changed #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
the
PR: Waiting for review
buhtz
changed the title
daviewales
commented
Sep 4, 2024
buhtz
added
the
PR: Modifications requested
|
Do you think the PR is finished on your side? In this case I would re-label it as "RequestToReview" and see if we can get some more feedback from others. btw: You should click on "Update branch" and resolve merge conflicts if they appear. |
Before, the cached SSH password would be used without checking if it was valid. Now, we check if it's valid before using it. If it's not valid, we ask the user to enter a new password before proceeding. Fixes bit-team#1852
daviewales
force-pushed
the
validate-ssh-password
branch
from
c3bd0a1
to
70db4a0
Compare
|
I don't think I can add labels, but yes, I think it's ready for review. |
buhtz
added
High
and removed
PR: Modifications requested
|
Once again, a big thank you for your contribution! My request for a review on the mailing list did not receive any response. A new release is not planned in the near future, so it shouldn't be a big problem. |
buhtz
added
the
PR: Merge after creative-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the cached SSH password would be used without checking if it was valid. Now, we check if it's valid before using it. If it's not valid, we ask the user to enter a new password before proceeding.
Fixes #1852