refactor: Separate code about Manage profile dialog #1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added a commit
that referenced
this pull request
Sep 13, 2024
Comprehensive and complex refactoring and also code moving. The method Config.setSnapshotsPaths() has to much logic in it, not belonging in that method nor into its class. Code was extracted and "parked" in the tools.py module. This in consequences gives the ability to easier decouple code in SettingsDialog.saveProfile() (PR #1865). Prepares for a new config management class (PR #1850) and refactoring the manage profiles dialog (PR #1865). Close #1864
This was referenced Sep 13, 2024
buhtz
added
the
PR: Waiting for review
|
OK, I did manual testing. The PR is ready to review and merge. |
buhtz
added
the
PR: Merge after creative-break
buhtz
added a commit
that referenced
this pull request
Oct 17, 2024
Each tabsin Manage Profiles dialog now with its own py-file, except Exclude and Include tab. Follow-up of PR #1865.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by
About he PR
manageprofiles).IMHO a code review makes not much sense because there was to much code that is modified. Testing the dialog and its features (e.g. in a VM) would make more sense and has more value.