Improve peer delegate #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
peers-item-delegate
branch
3 times, most recently
from
4aa6f95
to
e7c5711
Compare
MarnixCroes
reviewed
Nov 30, 2023
There was a problem hiding this comment.
running e7c5711
there is still a little overlap?
and some part is cut off
promag
force-pushed
the
peers-item-delegate
branch
from
e7c5711
to
04d9f0d
Compare
|
@MarnixCroes please recheck. |
|
@promag starting to look good!
|
promag
force-pushed
the
peers-item-delegate
branch
from
04d9f0d
to
c54c973
Compare
MarnixCroes
reviewed
Dec 1, 2023
There was a problem hiding this comment.
tack c54c973
only one comment: I think it is good to have the address displayed in full (without ... in middle) somewhere
WDYT?
There are designs for "Peer details" that we have plans to implement that I think should satisfy that. |
|
@johnny9 ok, I wasn't aware of that. that's fine. thanks for sharing. |
|
ack c54c973 |
johnny9
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Qt
ItemDelegateand use propertiesdownandhovered, making it possible to drop theMouseAreaAlso improve the layout and elide the label that can overflow.fixes #372.