Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix broken jobs #407

Merged
merged 6 commits into from
Jun 9, 2024
Merged

ci: Fix broken jobs #407

merged 6 commits into from
Jun 9, 2024

Commits on Jun 8, 2024

  1. ci: Delete no longer needed workaround in native Windows job 

    See actions/runner-images#9701.
    @hebasto
    hebasto committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    c0e608a View commit details
    Browse the repository at this point in the history

  2. build, msvc: Update vcpkg baseline

    @hebasto
    hebasto committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    5cbb35b View commit details
    Browse the repository at this point in the history

  3. build: disable external-signer for Windows 

    It's come to light that Boost ASIO (a Boost Process sub dep) has in some
instances, been queitly initialising our network stack on Windows (see
PR #28486 and discussion in #28940).

This has been shielding a bug in our own code, but the larger issue
is that Boost Process/ASIO is running code before main, and doing things
like setting up networking. This undermines our own assumptions about
how our binary works, happens before we get to run any sanity checks,
and also runs before we call our own code to setup networking.

It's also not clear why a feature like external signer would have a
dependency that would be doing anything network/socket related, given it
only exists to spawn a local process.
    @fanquake @hebasto
    fanquake authored and hebasto committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    91a2b37 View commit details
    Browse the repository at this point in the history

  4. ci: Disable benchmarks for "Win64 native" job 

    Can be reverted back after syncing the QML repository with the main one.
    @hebasto
    hebasto committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    6a4f027 View commit details
    Browse the repository at this point in the history

  5. ci: Disable fuzz tests for "macOS 13 native" job 

    Fuzz tests cause timeout for reasons unrelated to the QML GUI
development.

Can be reverted back after syncing the QML repository with the main one.
    @hebasto
    hebasto committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    568dbbe View commit details
    Browse the repository at this point in the history

  6. ci: Set IN_GETOPT_BIN environment variable for native macOS job

    @hebasto
    hebasto committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    d04cfc9 View commit details
    Browse the repository at this point in the history