Add used balance to overview page #775
Conversation
Add used balance to overview page for wallets with avoid_reuse flag enabled
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
| <string>Your current used balance</string> | ||
| </property> | ||
| <property name="text"> | ||
| <string notr="true">21 000 000.00000000 BTC</string> |
There was a problem hiding this comment.
| <cursorShape>IBeamCursor</cursorShape> | ||
| </property> | ||
| <property name="toolTip"> | ||
| <string>Your current used balance</string> |
There was a problem hiding this comment.
Because the space is tiny, and the impact should be big, every word in an effective tooltip needs to pack a punch.
Source: Internet
as the tooltip for the "used" line of the "balances" block,
"your current used balance" doesnt feel like a great tooltip
hebasto
changed the title
|
🤔 There hasn't been much activity lately and the CI seems to be failing. If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in. |
|
What is the use case here? (And the avoid_reuse flag in general...) |
If you are still working on this PR, please address bitcoin/bitcoin#28776 (comment). |
|
@hebasto Sorry I will be updating the PR description There was a change in implementation. I created a different PR (bitcoin/bitcoin#29062) based on the recommendation to refactor the |
Okay. Until then, marking this PR as a draft. |
|
🤔 There hasn't been much activity lately and the CI seems to be failing. If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in. |
1 similar comment
|
🤔 There hasn't been much activity lately and the CI seems to be failing. If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in. |
Second part: Fixes #769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
Prerequsite:
overview page when avoid_reuse is enabled
overview page when avoid_reuse is not enabled
