Renames config file to sim file #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
approved these changes
Oct 5, 2023
Currently we are using the term config file for the file that contains the simulation details. This is kind of fine for now, but it will get messy down the line when we want to start storing default values for the CLI parameters in a config file. Furthermore, we are requiring the config file to be passed, but `--config` is required. This both renames config to sim, and makes the parameter positional instead of named.
sr-gi
force-pushed
the
20231005-simfile
branch
from
9add2c9 to
4db438c
Compare
carlaKC
approved these changes
Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using the term config file for the file that contains the simulation details. This is kind of fine for now, but it will get messy down the line when we want to start storing default values for the CLI parameters in a config file. Furthermore, we are requiring the config file to be passed, but
--configis required.This both renames config to sim, and makes the parameter positional instead of named.