Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCO-170: replace go-bt with go-sdk #561

Merged
merged 12 commits into from
Aug 22, 2024

Conversation

pawellewandowski98
Copy link
Collaborator

Description

  • replaced go-bt with go-sdk
  • go-bt cannot be removed entirely because go-bc (which cannot be replaced - not every method is in go-sdk) is using it

internal/beef/beef.go Outdated Show resolved Hide resolved
internal/beef/beef_test.go Outdated Show resolved Hide resolved
internal/beef/beef_test.go Show resolved Hide resolved
internal/fees/fees.go Show resolved Hide resolved
internal/validator/default/default_validator.go Outdated Show resolved Hide resolved
internal/validator/default/default_validator.go Outdated Show resolved Hide resolved
internal/validator/default/default_validator.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
74.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@pawellewandowski98 pawellewandowski98 merged commit 31ff375 into main Aug 22, 2024
5 of 6 checks passed
@pawellewandowski98 pawellewandowski98 deleted the refactor/replace-go-bt-by-go-sdk branch August 22, 2024 09:21
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
* ARCO-170: replace go-bt with go-sdk

* ARCO-170: replace unused replace

* ARCO-170: update go.mod

* ARCO-170: replace go-bt after rebase

* ARCO-170: regenerate mocks

* ARCO-170: revert change in tests

* ARCO-170: fix test

* ARCO-170: fix PR comments

* ARCO-170: reorganize imports

* ARCO-170: add sdkTx alias to sdk.Transaction package

* ARCO-170: remove unused comments

* ARCO-170: update alias in e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants