Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docu/update #562

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Docu/update #562

merged 5 commits into from
Aug 21, 2024

Conversation

boecklim
Copy link
Collaborator

Description of Changes

  • Change main message of cumulative fee validation error to cumulative fee validation failed as the message can be misleading if the error happens due to too many unconfirmed parents.
  • Rename all .yml files to .yaml for consistency
  • Remove file ending from -config flag description as viper can read multiple file formats (json, yaml, toml, etc)
  • Remove numerical values from status descriptions as they're internal to ARC and defined in the /internal folder
  • Remove duplicate docker-compose file and replace by additional make command make run for running ARC without e2e tests

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@boecklim boecklim merged commit d945041 into main Aug 21, 2024
5 of 6 checks passed
@boecklim boecklim deleted the docu/update branch August 21, 2024 13:50
github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
@boecklim
Docu/update (#562)
266d1a4 
* Rename all .yml files to .yaml for consistency

* Remove file ending from -config flag description

* Remove numerical values from status descriptions

* Change main message of cumulative fee validation error

* Remove duplicate docker-compose file and replace by additional make command for running ARC without e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawellewandowski98 pawellewandowski98 pawellewandowski98 approved these changes

@kuba-4chain kuba-4chain kuba-4chain approved these changes

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boecklim @pawellewandowski98 @kuba-4chain @arkadiuszos4chain