Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARCO-153: Parallelise Create UTXO #584

Merged
merged 7 commits into from
Sep 17, 2024
Merged

ARCO-153: Parallelise Create UTXO #584

merged 7 commits into from
Sep 17, 2024

Conversation

kameshraj23
Copy link
Collaborator

Description of Changes

broadcaster-cli utxos create command runs in sequence for each keyset given. That can be very slow to execute. It would be faster if the utxo creation would run in parallel.

One possible solution to that is to create a MultiKeyUTXOCreator which holds a slice of UTXOCreator similar to how the MultiKeyRateBroadcaster

Screenshot 2024-09-10 at 10 39 28

boecklim
boecklim requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@boecklim boecklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@boecklim boecklim assigned boecklim and kameshraj23 and unassigned boecklim Sep 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
32.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@boecklim boecklim merged commit a669b24 into main Sep 17, 2024
5 of 6 checks passed
@boecklim boecklim deleted the parallelise/utxo-create branch September 17, 2024 08:08
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@kameshraj23
ARCO-153: Parallelise Create UTXO (#584)
9a96a30 
* ARCO-153: Parallelise Create UTXO

* running the format of the files

* ARCO-153: addressing the review comments

* ARCO-153: addressing the review comment and also adding unit test

* ARCO-153: fixing fmt.Errorf for pipeline failure

* ARCO-153: addressing review comments to add back comments

* ARCO-153: addressing review comments for adding wait group before go routine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boecklim boecklim boecklim approved these changes

Assignees

@kameshraj23 kameshraj23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kameshraj23 @boecklim