Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/revive linter #594

Merged
merged 18 commits into from
Oct 30, 2024
Merged

Refactor/revive linter #594

merged 18 commits into from
Oct 30, 2024

Conversation

boecklim
Copy link
Collaborator

@boecklim boecklim commented Sep 19, 2024 •
edited
Loading

Description of Changes

  • Added revive linter
  • Fixed issues highlighted by linter

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@pawellewandowski98 pawellewandowski98 marked this pull request as ready for review October 3, 2024 09:40
kuba-4chain
kuba-4chain reviewed Oct 3, 2024
View reviewed changes
cmd/arc/services/api.go Outdated Show resolved Hide resolved
internal/blocktx/health_check_test.go Show resolved Hide resolved
internal/blocktx/processor_test.go Outdated Show resolved Hide resolved
internal/callbacker/callbacker.go Outdated Show resolved Hide resolved
internal/metamorph/store/store.go Show resolved Hide resolved
internal/validator/beef/beef_validator.go Show resolved Hide resolved
@kuba-4chain
Copy link
Collaborator

Overall, this linter seems very helpful, but I think we could configure it a bit, so it's more helpful than harmful for the development process in Arc codebase.

These are my suggestions of rules to disable:

  • unused-parameter
  • var-name
  • var-declaration
  • exported (this one can stay if we decide we want it)

boecklim
boecklim commented Oct 23, 2024
View reviewed changes
.golangci.yml Outdated Show resolved Hide resolved
boecklim
boecklim commented Oct 23, 2024
View reviewed changes
cmd/arc/services/blocktx.go Outdated Show resolved Hide resolved
boecklim
boecklim commented Oct 23, 2024
View reviewed changes
examples/simple/main.go Outdated Show resolved Hide resolved
boecklim
boecklim commented Oct 23, 2024
View reviewed changes
internal/blocktx/server.go Outdated Show resolved Hide resolved
boecklim
boecklim commented Oct 23, 2024
View reviewed changes
pkg/keyset/key_set.go Outdated Show resolved Hide resolved
boecklim
boecklim commented Oct 23, 2024
View reviewed changes
pkg/metamorph/client.go Outdated Show resolved Hide resolved
kuba-4chain
kuba-4chain approved these changes Oct 30, 2024
View reviewed changes
pkg/blocktx/client.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@boecklim boecklim merged commit 0a54194 into main Oct 30, 2024
6 checks passed
@boecklim boecklim deleted the refactor/revive-linter branch October 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawellewandowski98 pawellewandowski98 pawellewandowski98 left review comments

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

@kuba-4chain kuba-4chain kuba-4chain approved these changes

Assignees

@pawellewandowski98 pawellewandowski98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boecklim @kuba-4chain @pawellewandowski98 @arkadiuszos4chain