-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new config for ipv6 related changes #624
base: main
Are you sure you want to change the base?
Conversation
8968c28
to
ac1ea33
Compare
ac1ea33
to
0ec075c
Compare
Nice work. I just have a question, because maybe I'm missing something, this config is a preparation for further changes to implement the IPv6 communications, but for now it's not yet being used anywhere, right? |
I see two potential approaches: 1. Use P2P for MulticastingNot my preferred option, but workable.
2. Implement a Multicast Handler (that works alongside P2P)
I believe that |
yeap, exactly |
test/config/config.yaml
Outdated
multicast: | ||
ipv6Enabled: true # indicates whether ipv6 is enabled for multicasting | ||
multicastGroups: # must be specified if mode = multicast | ||
- "172.28.56.77" # address of multicast group, needs to be ipv6 address if ipv6 is enabled | ||
interfaces: | ||
- "eth0" | ||
- "eth1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This can be removed I think
Quality Gate passedIssues Measures |
Description of Changes
New config parameters for ipv6 related changes
Linked Issues / Tickets
Closes #ARCO-229
Testing Procedure
I have added test case to check if all the values are correctly read from config
Checklist:
CHANGELOG.md
with my changes