-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BUX-605): gin logs & debugPrint handled by zerolog #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Testsπ Manual testing by @pawellewandowski98 resulted in success. |
Nazarii-4chain
approved these changes
Feb 19, 2024
chris-4chain
commented
Feb 19, 2024
kuba-4chain
reviewed
Feb 19, 2024
kuba-4chain
approved these changes
Feb 20, 2024
arkadiuszos4chain
approved these changes
Feb 20, 2024
kuba-4chain
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This PR addresses several aspects of logging within a Gin application:
debugPrint
functionimplemented in gin as: (fmt.Fprintf(DefaultWriter, "[GIN-debug] " + format, values...))
has been configured to use our zerolog logger by setting theDefaultWriter
early in the initialization process.DefaultErrorWriter
has also been set to use our zerolog logger. This ensures that errors, such as those caught bygin.Recovery()
, are logged consistently.How it works:
DefaultWriter
).DefaultErrorWriter
).Release Mode:
I've added a new configuration option release_mode (true/false) to control Gin's debug mode. Setting this to true is essential for production environments.
Example log record:
Info about
DefaultWriter
:gin-gonic/gin#1877 (comment)