Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(188): improving the way initial headers are preloaded, reducing headers file size #213

Merged
merged 16 commits into from
Mar 6, 2024
Merged

feat(188): improving the way initial headers are preloaded, reducing headers file size #213

merged 16 commits into from
Mar 6, 2024

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Feb 27, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Now the csv file is reduced to the essential fields (version, merkleroot, nonce, bits, timestamp), the other fields stored in the database are calculated during the import process

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @wregulski resulted in success.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 27, 2024
View reviewed changes
database/import.go Fixed Show fixed Hide fixed
database/import.go Fixed Show fixed Hide fixed
database/import.go Fixed Show fixed Hide fixed
@jakubmkowalski jakubmkowalski marked this pull request as draft February 27, 2024 15:43
@jakubmkowalski jakubmkowalski marked this pull request as ready for review February 27, 2024 18:29
kuba-4chain
kuba-4chain reviewed Feb 28, 2024
View reviewed changes
database/postgresql_adapter.go Outdated Show resolved Hide resolved
database/postgresql_adapter.go Outdated Show resolved Hide resolved
database/sqlite_adapter.go Outdated Show resolved Hide resolved
database/sqlite_adapter.go Outdated Show resolved Hide resolved
database/import.go Outdated Show resolved Hide resolved
database/import.go Outdated Show resolved Hide resolved
arkadiuszos4chain
arkadiuszos4chain requested changes Feb 29, 2024
View reviewed changes
database/import.go Outdated Show resolved Hide resolved
database/import.go Outdated Show resolved Hide resolved
database/postgresql_adapter.go Outdated Show resolved Hide resolved
database/postgresql_adapter.go Outdated Show resolved Hide resolved
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner March 4, 2024 14:15
@dorzepowski dorzepowski self-requested a review March 5, 2024 10:07
dorzepowski
dorzepowski approved these changes Mar 5, 2024
View reviewed changes
database/import.go Outdated Show resolved Hide resolved
database/sqlite_adapter.go Outdated Show resolved Hide resolved
database/import_test.go Outdated Show resolved Hide resolved
database/import_test.go Outdated Show resolved Hide resolved
database/import_test.go Outdated Show resolved Hide resolved
database/import_test.go Show resolved Hide resolved
database/import_test.go Outdated Show resolved Hide resolved
database/import.go Outdated Show resolved Hide resolved
dorzepowski
dorzepowski requested changes Mar 5, 2024
View reviewed changes
database/import.go Outdated Show resolved Hide resolved
dorzepowski
dorzepowski requested changes Mar 6, 2024
View reviewed changes
database/import.go Outdated Show resolved Hide resolved
@jakubmkowalski @dorzepowski
feat: add fields calculation for db while importing headers from prep…
fbd74b0 
…ared csv
@jakubmkowalski @dorzepowski
feat: add tests for record preparing
d5fbd32
@jakubmkowalski @dorzepowski
fix: fix export query
d6f794f
@jakubmkowalski @dorzepowski
feat: add reduced csv database file
6dc391a
@jakubmkowalski @dorzepowski
feat: add error handling for record preparation
b27a57a
@jakubmkowalski @dorzepowski
feat: add check for number of elements in row
306e701
@jakubmkowalski @dorzepowski
feat: add error path tests
1076f0c
@jakubmkowalski @dorzepowski
fix: fix shadow declaration
a3a1a81
@jakubmkowalski @dorzepowski
feat: remove unnecessary functions, fix parsing to int32 and uint32
2ae6613
@jakubmkowalski @dorzepowski
feat: change tests structure, add more error path cases
50dd1e2
@jakubmkowalski @dorzepowski
feat: changes after review
843cde2
@jakubmkowalski @dorzepowski
fix: correct name of variable to store number of elements in row
f5ac5f8
@jakubmkowalski @dorzepowski
fix: test adjustments
b134bf1
@jakubmkowalski @dorzepowski
feat: move definition of blockHasher to the method, where it is used
4fc0b9d
@jakubmkowalski @dorzepowski
feat: change prepareRecord to private, add better errors descritions,…
b1591ea 
… add checkpoints, update tests
@wregulski
Copy link
Contributor

testing

@wregulski wregulski added the tested PR was tested by a team member label Mar 6, 2024
@jakubmkowalski jakubmkowalski merged commit 1f1b671 into master Mar 6, 2024
9 checks passed
@jakubmkowalski jakubmkowalski deleted the feat/188-reduce-headers-file branch March 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorzepowski dorzepowski dorzepowski approved these changes

@kuba-4chain kuba-4chain kuba-4chain approved these changes

@arkadiuszos4chain arkadiuszos4chain arkadiuszos4chain approved these changes

Assignees

@jakubmkowalski jakubmkowalski

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakubmkowalski @wregulski @dorzepowski @kuba-4chain @arkadiuszos4chain