Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(SPV-906): use split linter configuration in reusable workflow #261

Merged
merged 5 commits into from
Jul 2, 2024
Merged

ci(SPV-906): use split linter configuration in reusable workflow #261

merged 5 commits into from
Jul 2, 2024

Conversation

dorzepowski
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner June 28, 2024 11:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@dorzepowski dorzepowski force-pushed the ci/update-on-push-to-use-split-linter branch from bcc9832 to 6faf2bb Compare July 1, 2024 05:31
@dorzepowski dorzepowski force-pushed the ci/update-on-push-to-use-split-linter branch from 6faf2bb to 9288096 Compare July 1, 2024 05:35
chris-4chain
chris-4chain approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@chris-4chain chris-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ac4ch
ac4ch reviewed Jul 2, 2024
View reviewed changes
cmd/main.go Outdated Show resolved Hide resolved
ac4ch
ac4ch reviewed Jul 2, 2024
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
ac4ch
ac4ch reviewed Jul 2, 2024
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
ac4ch
ac4ch reviewed Jul 2, 2024
View reviewed changes
config/defaults.go Outdated Show resolved Hide resolved
ac4ch
ac4ch reviewed Jul 2, 2024
View reviewed changes
database/database.go Outdated Show resolved Hide resolved
ac4ch
ac4ch reviewed Jul 2, 2024
View reviewed changes
database/sql/headers.go Outdated Show resolved Hide resolved
ac4ch
ac4ch requested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@ac4ch ac4ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please corect SQL acronym and avoid of finishing if block with else if

@dorzepowski
ci(SPV-906): change Postgresql to PostgreSQL, and Sqlite to SQLite na…
48ba28b 
…mes; adjust changes in if statements to be more readable;
@dorzepowski dorzepowski force-pushed the ci/update-on-push-to-use-split-linter branch from 2a22ec7 to 48ba28b Compare July 2, 2024 07:39
@chris-4chain chris-4chain added the tested PR was tested by a team member label Jul 2, 2024
@dorzepowski dorzepowski merged commit 02cf745 into main Jul 2, 2024
14 of 16 checks passed
@dorzepowski dorzepowski deleted the ci/update-on-push-to-use-split-linter branch July 2, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac4ch ac4ch ac4ch approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorzepowski @ac4ch @chris-4chain