Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(SPV-1106): introduce new bhs errors #294

Merged
merged 12 commits into from
Oct 25, 2024
Merged

feature(SPV-1106): introduce new bhs errors #294

merged 12 commits into from
Oct 25, 2024

Conversation

dzolt-4chain
Copy link
Contributor

@dzolt-4chain dzolt-4chain commented Oct 22, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@dzolt-4chain dzolt-4chain requested a review from a team as a code owner October 22, 2024 11:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @jakubmkowalski resulted in success.

chris-4chain
chris-4chain approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@chris-4chain chris-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙈 😛

@dzolt-4chain dzolt-4chain marked this pull request as draft October 23, 2024 12:08
@dzolt-4chain dzolt-4chain marked this pull request as ready for review October 24, 2024 13:05
@dzolt-4chain dzolt-4chain added test Unit tests, mocking, integration testing and removed test Unit tests, mocking, integration testing labels Oct 24, 2024
jakubmkowalski
jakubmkowalski reviewed Oct 25, 2024
View reviewed changes
bhserrors/definitions.go Outdated Show resolved Hide resolved
database/sql/tokens.go Show resolved Hide resolved
database/sql/tokens.go Show resolved Hide resolved
database/sql/webhooks.go Show resolved Hide resolved
transports/http/endpoints/api/headers/header_endpoints_test.go Outdated Show resolved Hide resolved
@jakubmkowalski jakubmkowalski added regression-tests Runs regression tests tested PR was tested by a team member labels Oct 25, 2024
@dzolt-4chain dzolt-4chain merged commit e035b3e into main Oct 25, 2024
14 of 15 checks passed
@dzolt-4chain dzolt-4chain deleted the feature/SPV-1106 branch October 25, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubmkowalski jakubmkowalski jakubmkowalski approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees
No one assigned
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzolt-4chain @chris-4chain @jakubmkowalski