Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-960): Replaced any with types #989

Merged
merged 24 commits into from
Aug 29, 2024
Merged

feat(SPV-960): Replaced any with types #989

merged 24 commits into from
Aug 29, 2024

Conversation

Nazarii-4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@Nazarii-4chain Nazarii-4chain requested a review from a team as a code owner August 7, 2024 09:23
@Nazarii-4chain Nazarii-4chain self-assigned this Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

swierzbicki
swierzbicki suggested changes Aug 7, 2024
View reviewed changes
Copy link

@swierzbicki swierzbicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.Added some comments
2. Code doesn't compile

src/components/ContactAcceptDialog/ContactAcceptDialog.tsx Outdated Show resolved Hide resolved
src/components/ContactsTabContent/ContactsTabContent.tsx Outdated Show resolved Hide resolved
src/components/ViewDialog/ViewDialog.tsx Outdated Show resolved Hide resolved
src/logger/index.ts Show resolved Hide resolved
dorzepowski
dorzepowski requested changes Aug 16, 2024
View reviewed changes
src/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/components/ViewDialog/ViewDialog.tsx Outdated Show resolved Hide resolved
src/logger/index.ts Outdated Show resolved Hide resolved
@dorzepowski dorzepowski mentioned this pull request Aug 20, 2024
Closed
@swierzbicki swierzbicki self-requested a review August 21, 2024 07:08
@Nazarii-4chain
feat(SPV-960): improved props logic
7f93bf8
@Nazarii-4chain
Merge branch 'adminV2' of https://github.com/bitcoin-sv/spv-wallet-admin
39b4203 
 into SPV-960/FixAnyIssues

# Conflicts:
#	src/routes/admin/_admin.access-keys.tsx
#	src/routes/admin/_admin.contacts.tsx
#	src/routes/admin/_admin.transactions.tsx
#	src/routes/user/_user.access-keys.tsx
#	src/routes/user/_user.transactions.tsx
dorzepowski
dorzepowski requested changes Aug 22, 2024
View reviewed changes
src/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
@bitcoin-sv bitcoin-sv deleted a comment from swierzbicki Aug 23, 2024
@swierzbicki swierzbicki removed their request for review August 23, 2024 12:07
@chris-4chain chris-4chain added the tested PR was tested by a team member label Aug 29, 2024
@Nazarii-4chain Nazarii-4chain merged commit 6fc42f6 into adminV2 Aug 29, 2024
5 checks passed
@Nazarii-4chain Nazarii-4chain deleted the SPV-960/FixAnyIssues branch August 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swierzbicki swierzbicki swierzbicki approved these changes

@dorzepowski dorzepowski dorzepowski approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees

@Nazarii-4chain Nazarii-4chain

Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nazarii-4chain @swierzbicki @dorzepowski @chris-4chain