feat(SPV-1095): add merkleroots sync to go client #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Tests💚 Manual testing by @jakubmkowalski resulted in success. |
chris-4chain
reviewed
Oct 3, 2024
chris-4chain
approved these changes
Oct 3, 2024
dzolt-4chain
force-pushed
the
feat/SPV-1095
branch
from
31889cf
to
1f8c28c
Compare
chris-4chain
approved these changes
Oct 10, 2024
dorzepowski
requested changes
Oct 10, 2024
dorzepowski
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR does not include any new tests because regression tests are created in a separate service. Additionally, the structure of the sync merkleroots cannot guarantee consistent test results due to the ongoing growth of the blockchain.
Furthermore, xpriv is used here instead of xpub, as in contrast to jsclient, because there is no straightforward way to handle xpub authentication in go client. Using xpriv with the sign flag set to true automatically sets the authorization header as xpub.
Any reviewers that want to discuss any of these issues please feel free to do so in the comments.