Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(XXX): remove go-client models and replace them with spv-wallet ones for sync merkleroots #280

Merged
merged 4 commits into from
Oct 17, 2024
Merged

refactor(XXX): remove go-client models and replace them with spv-wallet ones for sync merkleroots #280

merged 4 commits into from
Oct 17, 2024

Conversation

dzolt-4chain
Copy link
Contributor

@dzolt-4chain dzolt-4chain commented Oct 16, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@dzolt-4chain dzolt-4chain requested a review from a team as a code owner October 16, 2024 08:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @ac4ch resulted in success.

Nazarii-4chain
Nazarii-4chain reviewed Oct 16, 2024
View reviewed changes
sync_merkleroots.go Outdated Show resolved Hide resolved
sync_merkleroots.go Outdated Show resolved Hide resolved
sync_merkleroots.go Outdated Show resolved Hide resolved
dzolt-4chain and others added 3 commits October 16, 2024 11:05
@dzolt-4chain @Nazarii-4chain
Update sync_merkleroots.go
d244b44 
Co-authored-by: Nazarii-4chain <[email protected]>
@dzolt-4chain @Nazarii-4chain
Update sync_merkleroots.go
8f3bdd7 
Co-authored-by: Nazarii-4chain <[email protected]>
@dzolt-4chain @Nazarii-4chain
Update sync_merkleroots.go
aa3d60b 
Co-authored-by: Nazarii-4chain <[email protected]>
@ac4ch ac4ch added the tested PR was tested by a team member label Oct 17, 2024
@dzolt-4chain dzolt-4chain merged commit 2372ff4 into main Oct 17, 2024
6 checks passed
@dzolt-4chain dzolt-4chain deleted the refactor/get-models-from-spv-wallet branch October 17, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac4ch ac4ch ac4ch approved these changes

@Nazarii-4chain Nazarii-4chain Nazarii-4chain approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzolt-4chain @ac4ch @Nazarii-4chain