BIP39: add license and copyright section #1680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required per BIP-2, and they avoid user confusion as seen in bitcoin#1395 (comment)
|
cc @prusnak for approval |
|
ACK |
|
is licensing and CLAs addressed in the new bip2 @murchandamus ? |
|
ACK MIT |
murchandamus
added
the
Pending acceptance
Just in so far as we have always required an "acceptable license" that permitted others to use the work. My new process BIP draft so far does not propose a CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are required for legal use, and also per BIP-2, and they avoid user confusion as seen in #1395 (comment).
Choice of MIT license per BIP author feedback in #1395 (comment).
The license omission was likely an oversight.
BIP-39 predates BIP-2 by 2-3 years. BIP-1 (in force at the time, since superseded by BIP-2) did require a copyright or public domain section.