Generate v1 -> v2 redirects for all production pages #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadalnix
requested changes
Sep 22, 2020
v2/gatsby-node.js
Outdated
| @@ -92,7 +100,7 @@ exports.createPages = async ({ graphql, actions, reporter }) => { | |||
| // In production, we redirect in-development v2 pages to v1 equivalent routes. | |||
| // In non-prod environments, we create all pages and do not redirect. | |||
| if (process.env.GATSBY_APP_ENV == "prod") { | |||
| await createRedirectForEachLocale(createRedirect, page) | |||
| await createRedirectForEachLocale(createRedirect, page, fromHtmlPage = false) | |||
There was a problem hiding this comment.
I'm pretty sure this creates a global variable and by no mean is a named argument
v2/gatsby-node.js
Outdated
| @@ -35,15 +35,23 @@ const createPageForEachLocale = async (createPage, page) => { | |||
| ) | |||
| } | |||
|
|
|||
| const createRedirectForEachLocale = async (createRedirect, page) => { | |||
| const createRedirectForEachLocale = async (createRedirect, page, fromHtmlPage = true) => { | |||
There was a problem hiding this comment.
Boolean in API = beark.
Just pass a customized version of createRedirect that do the switcharoo and rename a few things so that they make sense.
EyeOfPython
pushed a commit
to EyeOfPython/bitcoincash.org
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v1 pages on their way out, we need to redirect v1 pages to v2 pages. This way, links to the old v1 routes will still work, but see the new experience.
This patch adds the necessary machinery to introduce those redirects and is testable as a stand-alone change. However, in order to push this to production, the v1 configs in nginx need to be cleaned up first. That patch will soon follow.
Test plan:
Navigate around. Pages still work as expected and v1 links such as
localhost:8000/start-here.htmlredirect to their appropriate v2 counterparts.In addition to the above tested behavior, pages in the jekyll migration directory still redirect in the v2 -> v1 direction as expected.