Bump bdk version to 1.0.0-alpha.3 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
bump_dev_1.0.0_alpha.3
branch
from
1c9254d
to
66b2175
Compare
|
Before we release alpha.3, I think it's important we include this commit: We have changed the wallet API to initialize and load as separate methods. However, the method to initialize a wallet will wipe the database (without the aforementioned commit). |
|
@evanlinjin I agree that it's an important change to include, can you link a PR containing that commit? (Preferably, containing only that commit, so we can review quickly) |
|
I agree, please make a PR for this commit and I'll add it to the alpha.3 release. |
|
Doing it soon! |
|
@evanlinjin I created #1256 for ya. Please ACK and merge or I'll merge it. |
notmandatory
force-pushed
the
bump_dev_1.0.0_alpha.3
branch
from
66b2175
to
4c490ba
Compare
Bump bdk_chain to 0.7.0 Bump bdk_bitcoin_rpc to 0.2.0 Bump bdk_electrum to 0.5.0
notmandatory
force-pushed
the
bump_dev_1.0.0_alpha.3
branch
from
4c490ba
to
0032711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Changelog notice
See #1254
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing