-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hwi,wallet): enhance hardware wallet integration and testing #1492
base: master
Are you sure you want to change the base?
Conversation
b8ea85a
to
8f19aa3
Compare
Thanks for this PR. I haven't had the opportunity to review this properly yet, however I am wondering if there is a particular reason why |
Also, can you please remove the merge commit and do a rebase instead? Thank you |
1193348
to
8f19aa3
Compare
OK.
|
8f19aa3
to
c335f35
Compare
Reorganized and moved Ready for review. Please take a look. |
It seems that the HWI emulator is disabled, which caused the HWI-related tests to fail. Therefore, I have added it (add HWI emulator setup). |
I appreciate what is accomplished in this PR. I'm somewhat ambivalent toward having this change. Main concern is bringing python dependency back to CI considering the age of this emulator software and that the nano s hasn't seen a firmware update since 2021 which amounts to more of a maintenance burden than I think is warranted. Other folks might have different opinions. In any case if you decide to continue work on this branch, we'd like if you also signed commits, although for the record I realized that policy isn't well documented. |
6e27d25
to
d817537
Compare
Thank you for your feedback. I've updated the emulator model used for the firmware to a more recent version. Additionally, I've resubmitted the commits with signatures. Thanks! |
Thanks for working on this! However, after #1561 the Feel free to open a PR in |
Overview
This PR introduces enhancements to the hardware wallet integration within the
hwi
crate and improves the testing utilities in thewallet
crate.Changes
test-util
FeatureThe
bdk_wallet
dependency in thehwi
crate now includes thetest-util
feature, allowing the use of additional testing utilities provided by thebdk_wallet
crate.TransactionSigner
implementationThe previously disabled hardware wallet signer test has been re-enabled and updated to use the
test-util
feature. This includes improvements to the test structure and error handling, ensuring robust and comprehensive testing.test-util
insidewallet
crateA new
test-util
module has been added to thewallet
crate to organize and provide utilities for testing. This promotes code reuse and maintainability across different tests.