Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Implement generics for CheckPoint, LocalChain, and spk_client types #1582

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

refactor: Implement generics for CheckPoint, LocalChain, and spk_client types #1582

wants to merge 4 commits into from

Conversation

LagginTimes
Copy link
Contributor

@LagginTimes LagginTimes commented Aug 29, 2024 •
edited
Loading

Description

This WIP PR is a step towards implementing header checkpointing for bdk_electrum. The goal is to be able to store whole headers in CheckPoint so they do not have to be re-downloaded. Current commit was based off of an earlier prototype PR and is a WIP.

TODO:

  • Change CheckPoint to take in a generic.
  • Change LocalChange to take in a generic.
  • Change spk_client types to take in generics.

Notes to the reviewers

Changelog notice

  • CheckPoint takes in a generic.
  • LocalChain and ChangeSet take in generics.
  • spk_client types can take in generics.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@LagginTimes LagginTimes marked this pull request as draft August 29, 2024 09:59
@LagginTimes LagginTimes changed the title refactor(core): CheckPoint takes a generic refactor(core): Implement generics for CheckPoint and LocalChain Aug 29, 2024
@LagginTimes LagginTimes force-pushed the generic_checkpoint branch 3 times, most recently from a899049 to 7c13781 Compare September 2, 2024 02:53
evanlinjin
evanlinjin reviewed Sep 2, 2024
View reviewed changes
crates/core/src/checkpoint.rs Outdated Show resolved Hide resolved
crates/core/src/checkpoint.rs Outdated Show resolved Hide resolved
@LagginTimes LagginTimes force-pushed the generic_checkpoint branch 2 times, most recently from ea1cf8b to bf90ea5 Compare September 3, 2024 06:15
@LagginTimes LagginTimes force-pushed the generic_checkpoint branch 5 times, most recently from c278804 to 6300d7c Compare September 5, 2024 03:43
@LagginTimes LagginTimes changed the title refactor(core): Implement generics for CheckPoint and LocalChain refactor(core): Implement generics for CheckPoint, LocalChain, and spk_client types Sep 5, 2024
@LagginTimes LagginTimes force-pushed the generic_checkpoint branch 3 times, most recently from 46e333d to 481f139 Compare September 5, 2024 04:39
@LagginTimes LagginTimes changed the title refactor(core): Implement generics for CheckPoint, LocalChain, and spk_client types refactor: Implement generics for CheckPoint, LocalChain, and spk_client types Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlinjin evanlinjin evanlinjin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@LagginTimes LagginTimes

Labels
None yet
Projects
BDK
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LagginTimes @evanlinjin