-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(chain): add several basic scenarios to test transaction conflicts #1739
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution! The test case involving two conflicting transactions with different |
OK. I've removed this redundant case. |
Could you please squash the second commit into the first one to keep the commit history clean? Everything will look good to me once that's done. Thanks! |
ba50fd7
to
8bda75d
Compare
Squash done. |
@pluveto could you please rebase on master to fix CI? We just merged the fix for CI. |
7ad264a
to
8374f70
Compare
Now it's rebased. |
ACK 8374f70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8374f70
8374f70
to
868739f
Compare
868739f
to
7c3f915
Compare
ACK 7c3f915 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7c3f915
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7c3f915
to
1cd0b4f
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 1cd0b4f
Description
This update introduces several test cases to validate the transaction conflict handling logic within the
TxGraph
. The tests encompass a range of scenarios including:only A exists
).B
andB'
spendingA
) under two basic conditions:last_seen
timestamp.Changelog Notice
TxGraph
.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing.