Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize OPS type from Record to Enum #2189

Merged
merged 12 commits into from
Dec 27, 2024
Merged

Optimize OPS type from Record to Enum #2189

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
38d0cc6
Merge branch 'master' of github.com:bitcoinjs/bitcoinjs-lib
decentraldev1 Dec 13, 2024
f103f7f
feat: use enum enhance OPS types
decentraldev1 Dec 13, 2024
a7b006d
feat: update OPS reference
decentraldev1 Dec 13, 2024
af5e572
wip: update OPS avoid duplicate value
decentraldev1 Dec 14, 2024
510d437
wip: build src
decentraldev1 Dec 14, 2024
13089db
wip: set REVERSE_OPS as alias of OPS
decentraldev1 Dec 14, 2024
305cab5
wip: remove REVERSE_OPS and add check if the chunk is a valid opcode …
decentraldev1 Dec 24, 2024
36fe2b8
test: add OPS test
decentraldev1 Dec 24, 2024
4365e64
test: add decodes OP_FALSE as empty buffer
decentraldev1 Dec 25, 2024
8bf16e9
test: add decodes a series of numbers from '82 to 96' correctly
decentraldev1 Dec 25, 2024
16d62c6
Merge branch 'master' of github.com:bitcoinjs/bitcoinjs-lib
decentraldev1 Dec 25, 2024
88bf9b7
test: optimize unit test
decentraldev1 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/script.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,29 @@ describe('script', () => {
});
});

describe('fromASM', () => {
const OPS = bscript.OPS;
it('decodes OP_FALSE as empty buffer', () => {
const string = 'OP_RETURN OP_FALSE';
assert.deepStrictEqual(
bscript.fromASM(string),
Uint8Array.from([OPS.OP_RETURN, OPS.OP_FALSE]),
);
});

it("decodes a series of numbers from '82 to 96' correctly", () => {
decentraldev1 marked this conversation as resolved.
Show resolved Hide resolved
const asm = Array.from({ length: 15 }, (_, i) =>
(i + 130).toString(16).padStart(2, '0'),
).join(' ');
const expected = Array.from({ length: 15 }, (_, i) => [
1,
i + 130,
]).flat();
const result = bscript.fromASM(asm);
assert.deepStrictEqual(result, Uint8Array.from(expected));
});
});

describe('toASM', () => {
const OP_RETURN = bscript.OPS.OP_RETURN;
it('encodes empty buffer as OP_0', () => {
Expand Down